| | | 1 | | using System.Collections.Generic; |
| | | 2 | | using System.Linq; |
| | | 3 | | using SwitchBlade.Contracts; |
| | | 4 | | |
| | | 5 | | namespace SwitchBlade.Services |
| | | 6 | | { |
| | | 7 | | public class WindowReconciler : IWindowReconciler |
| | | 8 | | { |
| | | 9 | | private readonly IIconService? _iconService; |
| | 79 | 10 | | private readonly Dictionary<IntPtr, List<WindowItem>> _windowItemCache = new(); |
| | | 11 | | // Performance optimization: Secondary index for O(1) provider lookups |
| | 79 | 12 | | private readonly Dictionary<IWindowProvider, HashSet<WindowItem>> _providerItems = new(); |
| | 79 | 13 | | private readonly object _lock = new(); |
| | | 14 | | |
| | | 15 | | private readonly ILogger? _logger; |
| | | 16 | | |
| | 79 | 17 | | public WindowReconciler(IIconService? iconService, ILogger? logger = null) |
| | 79 | 18 | | { |
| | 79 | 19 | | _iconService = iconService; |
| | 79 | 20 | | _logger = logger; |
| | 79 | 21 | | } |
| | | 22 | | |
| | | 23 | | public List<WindowItem> Reconcile(IList<WindowItem> incomingItems, IWindowProvider provider) |
| | 82 | 24 | | { |
| | 82 | 25 | | lock (_lock) |
| | 82 | 26 | | { |
| | 82 | 27 | | var resolvedItems = new List<WindowItem>(); |
| | 82 | 28 | | var claimedItems = new HashSet<WindowItem>(); |
| | | 29 | | |
| | | 30 | | // Performance optimization: O(1) lookup instead of O(N) SelectMany scan |
| | | 31 | | HashSet<WindowItem> unusedCacheItems; |
| | 82 | 32 | | if (_providerItems.TryGetValue(provider, out var existing)) |
| | 24 | 33 | | { |
| | 24 | 34 | | unusedCacheItems = new HashSet<WindowItem>(existing); |
| | 24 | 35 | | } |
| | | 36 | | else |
| | 58 | 37 | | { |
| | 58 | 38 | | unusedCacheItems = new HashSet<WindowItem>(); |
| | 58 | 39 | | } |
| | | 40 | | |
| | 414 | 41 | | foreach (var incoming in incomingItems) |
| | 84 | 42 | | { |
| | 84 | 43 | | WindowItem? match = null; |
| | | 44 | | |
| | 84 | 45 | | if (_windowItemCache.TryGetValue(incoming.Hwnd, out var candidates)) |
| | 38 | 46 | | { |
| | 83 | 47 | | match = candidates.FirstOrDefault(w => w.Title == incoming.Title && !claimedItems.Contains(w)) |
| | 60 | 48 | | ?? candidates.FirstOrDefault(w => !claimedItems.Contains(w)); |
| | 38 | 49 | | } |
| | | 50 | | |
| | 84 | 51 | | if (match != null) |
| | 31 | 52 | | { |
| | | 53 | | // Remove from hash sets BEFORE mutating Title (which affects hash code) |
| | 31 | 54 | | unusedCacheItems.Remove(match); |
| | | 55 | | |
| | 31 | 56 | | if (match.Source != null && _providerItems.TryGetValue(match.Source, out var providerSet)) |
| | 30 | 57 | | { |
| | 30 | 58 | | providerSet.Remove(match); |
| | 30 | 59 | | } |
| | | 60 | | |
| | 31 | 61 | | match.Title = incoming.Title; |
| | 31 | 62 | | match.ProcessName = incoming.ProcessName; |
| | 31 | 63 | | match.Source ??= provider; |
| | | 64 | | |
| | | 65 | | // Add back to provider sets if applicable |
| | 31 | 66 | | if (match.Source != null) |
| | 31 | 67 | | { |
| | 31 | 68 | | if (!_providerItems.TryGetValue(match.Source, out providerSet)) |
| | 1 | 69 | | { |
| | 1 | 70 | | providerSet = new HashSet<WindowItem>(); |
| | 1 | 71 | | _providerItems[match.Source] = providerSet; |
| | 1 | 72 | | } |
| | 31 | 73 | | providerSet.Add(match); |
| | 31 | 74 | | } |
| | | 75 | | |
| | | 76 | | // Icon population is now async - do NOT call PopulateIconIfMissing here |
| | | 77 | | |
| | 31 | 78 | | resolvedItems.Add(match); |
| | 31 | 79 | | claimedItems.Add(match); |
| | 31 | 80 | | } |
| | | 81 | | else |
| | 53 | 82 | | { |
| | 53 | 83 | | incoming.ResetBadgeAnimation(); |
| | 53 | 84 | | incoming.Source = provider; |
| | | 85 | | // Icon population is now async - do NOT call PopulateIconIfMissing here |
| | | 86 | | |
| | | 87 | | // Lock-free internal method — we already hold _lock |
| | 53 | 88 | | AddToCacheInternal(incoming); |
| | | 89 | | |
| | 53 | 90 | | resolvedItems.Add(incoming); |
| | 53 | 91 | | claimedItems.Add(incoming); |
| | 53 | 92 | | } |
| | 84 | 93 | | } |
| | | 94 | | |
| | | 95 | | // Cleanup unused items using lock-free internal method |
| | 260 | 96 | | foreach (var unused in unusedCacheItems) |
| | 7 | 97 | | { |
| | 7 | 98 | | RemoveFromCacheInternal(unused); |
| | 7 | 99 | | } |
| | | 100 | | |
| | 82 | 101 | | return resolvedItems; |
| | | 102 | | } |
| | 82 | 103 | | } |
| | | 104 | | |
| | | 105 | | public void PopulateIcons(IEnumerable<WindowItem> items) |
| | 32 | 106 | | { |
| | 59 | 107 | | if (_iconService == null) return; |
| | | 108 | | |
| | | 109 | | // No lock needed here - items are already reconciled and local to this list |
| | | 110 | | // Icon extraction is thread-safe and cached |
| | 5 | 111 | | int count = 0; |
| | 5 | 112 | | long start = System.Diagnostics.Stopwatch.GetTimestamp(); |
| | | 113 | | |
| | 29 | 114 | | foreach (var item in items) |
| | 7 | 115 | | { |
| | 7 | 116 | | if (item.Icon == null && !string.IsNullOrEmpty(item.ExecutablePath)) |
| | 4 | 117 | | { |
| | | 118 | | try |
| | 4 | 119 | | { |
| | 4 | 120 | | item.Icon = _iconService.GetIcon(item.ExecutablePath); |
| | 2 | 121 | | count++; |
| | 2 | 122 | | } |
| | 2 | 123 | | catch (Exception ex) |
| | 2 | 124 | | { |
| | 2 | 125 | | _logger?.LogError($"Failed to populate icon for {item.ExecutablePath}", ex); |
| | 2 | 126 | | } |
| | 4 | 127 | | } |
| | 7 | 128 | | } |
| | | 129 | | |
| | 5 | 130 | | if (count > 0 && _logger != null && _logger.IsDebugEnabled) |
| | 1 | 131 | | { |
| | 1 | 132 | | var elapsed = System.Diagnostics.Stopwatch.GetElapsedTime(start); |
| | 1 | 133 | | _logger.Log($"[Perf] Populated {count} icons in {elapsed.TotalMilliseconds:F2}ms"); |
| | 1 | 134 | | } |
| | 32 | 135 | | } |
| | | 136 | | |
| | | 137 | | public void AddToCache(WindowItem item) |
| | 9 | 138 | | { |
| | 9 | 139 | | lock (_lock) |
| | 9 | 140 | | { |
| | 9 | 141 | | AddToCacheInternal(item); |
| | 9 | 142 | | } |
| | 9 | 143 | | } |
| | | 144 | | |
| | | 145 | | public void RemoveFromCache(WindowItem item) |
| | 4 | 146 | | { |
| | 4 | 147 | | lock (_lock) |
| | 4 | 148 | | { |
| | 4 | 149 | | RemoveFromCacheInternal(item); |
| | 4 | 150 | | } |
| | 4 | 151 | | } |
| | | 152 | | |
| | | 153 | | /// <summary> |
| | | 154 | | /// Lock-free internal method for adding to cache. |
| | | 155 | | /// Caller must hold _lock. |
| | | 156 | | /// </summary> |
| | | 157 | | private void AddToCacheInternal(WindowItem item) |
| | 62 | 158 | | { |
| | | 159 | | // 1. Update HWND lookup |
| | 62 | 160 | | if (!_windowItemCache.TryGetValue(item.Hwnd, out var list)) |
| | 54 | 161 | | { |
| | 54 | 162 | | list = new List<WindowItem>(); |
| | 54 | 163 | | _windowItemCache[item.Hwnd] = list; |
| | 54 | 164 | | } |
| | 62 | 165 | | if (!list.Contains(item)) |
| | 60 | 166 | | list.Add(item); |
| | | 167 | | |
| | | 168 | | // 2. Update Provider lookup |
| | 62 | 169 | | if (item.Source != null) |
| | 60 | 170 | | { |
| | 60 | 171 | | if (!_providerItems.TryGetValue(item.Source, out var set)) |
| | 42 | 172 | | { |
| | 42 | 173 | | set = new HashSet<WindowItem>(); |
| | 42 | 174 | | _providerItems[item.Source] = set; |
| | 42 | 175 | | } |
| | 60 | 176 | | set.Add(item); |
| | 60 | 177 | | } |
| | 62 | 178 | | } |
| | | 179 | | |
| | | 180 | | /// <summary> |
| | | 181 | | /// Lock-free internal method for removing from cache. |
| | | 182 | | /// Caller must hold _lock. |
| | | 183 | | /// </summary> |
| | | 184 | | private void RemoveFromCacheInternal(WindowItem item) |
| | 11 | 185 | | { |
| | | 186 | | // 1. Remove from HWND lookup |
| | 11 | 187 | | if (_windowItemCache.TryGetValue(item.Hwnd, out var list)) |
| | 11 | 188 | | { |
| | 11 | 189 | | list.Remove(item); |
| | 11 | 190 | | if (list.Count == 0) |
| | 11 | 191 | | _windowItemCache.Remove(item.Hwnd); |
| | 11 | 192 | | } |
| | | 193 | | |
| | | 194 | | // 2. Remove from Provider lookup |
| | 11 | 195 | | if (item.Source != null && _providerItems.TryGetValue(item.Source, out var set)) |
| | 9 | 196 | | { |
| | 9 | 197 | | set.Remove(item); |
| | 9 | 198 | | if (set.Count == 0) |
| | 3 | 199 | | _providerItems.Remove(item.Source); |
| | 9 | 200 | | } |
| | 11 | 201 | | } |
| | | 202 | | |
| | | 203 | | public int CacheCount |
| | | 204 | | { |
| | | 205 | | get |
| | 1 | 206 | | { |
| | 1 | 207 | | lock (_lock) |
| | 1 | 208 | | { |
| | 2 | 209 | | return _windowItemCache.Count + _providerItems.Values.Sum(s => s.Count); |
| | | 210 | | } |
| | 1 | 211 | | } |
| | | 212 | | } |
| | | 213 | | |
| | | 214 | | public int GetHwndCacheCount() |
| | 9 | 215 | | { |
| | 9 | 216 | | lock (_lock) |
| | 9 | 217 | | { |
| | 16 | 218 | | return _windowItemCache.Values.Sum(l => l.Count); |
| | | 219 | | } |
| | 9 | 220 | | } |
| | | 221 | | |
| | | 222 | | public int GetProviderCacheCount() |
| | 4 | 223 | | { |
| | 4 | 224 | | lock (_lock) |
| | 4 | 225 | | { |
| | 7 | 226 | | return _providerItems.Values.Sum(s => s.Count); |
| | | 227 | | } |
| | 4 | 228 | | } |
| | | 229 | | |
| | | 230 | | } |
| | | 231 | | } |